Please don't use implicit variable declarations! #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be an error when running JavaScript in ES5 "strict mode," because implicit variables in JavaScript become globals. It's a small thing, but having the declaration (const/let/var, whichever -- although I've used `const` out of preference), will hopefully reduce confusion for beginners (who should expect all variables to be declared!) and make the code more idiomatic.
|
|
jennifer-shehane
approved these changes
Oct 17, 2017
There was a problem hiding this comment.
Thanks for the catch! It's really important to us to have examples copy/paste-able and be valid.
We initially wrote the docs in ES5 but have the intention of updating everything to ES6, so there are definitely some ES5 examples floating around, but const is a good choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be an error when running JavaScript in ES5 "strict mode," because implicit variables in JavaScript become globals. It's a small thing, but having the declaration (const/let/var, whichever -- although I've used
constout of preference), will hopefully reduce confusion for beginners (who should expect all variables to be declared!) and make the code more idiomatic.