Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

117 Add supported Platforms #119

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Conversation

arnazmursidp
Copy link
Contributor

#117
[x] Add Cypress' supported OS version readme

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Arnaz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bahmutov
Copy link
Contributor

@arnazmursidp

Thank you for the submission, we appreciate it. Could you add to the windows line a recommendation to watch cypress-io/cypress#74 to know the windows support status?

Also, the CLA seems to not find your email from the commit?

@arnazmursidp
Copy link
Contributor Author

oh okay i'll fix it, sorry

@jennifer-shehane
Copy link
Member

@arnazmursidp
Copy link
Contributor Author

Hi @jennifer-shehane i couldn't find the page and what the message were, cause there are no exclamation mark as they said in the documentation

@RandallKent
Copy link
Contributor

RandallKent commented Oct 4, 2017

Hey @arnazmursidp!

I cloned your repo and ran git show cd03853296f87605f5ee12a5c7a58cdab96adda7 which shows the email address that needs to be added to your GitHub account to be xxx.

Let me know once it has been added and I'll remove it from this comment to keep the spambots away 😄

@arnazmursidp
Copy link
Contributor Author

@RandallKent oh thank you for the confirmation, but I already set thet email to be my primary email, i don't really know what is wrong...

@bahmutov
Copy link
Contributor

bahmutov commented Oct 6, 2017

I see CLA signed by arnazmursidp not sure why check has not passed. Will approve and merge, thank you @arnazmursidp !

@bahmutov bahmutov merged commit 27626ba into cypress-io:develop Oct 6, 2017
@arnazmursidp
Copy link
Contributor Author

@bahmutov thank you so much, thanks for letting me in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants