Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS broken in docs-staging #67

Closed
jennifer-shehane opened this issue Sep 12, 2017 · 1 comment
Closed

CSS broken in docs-staging #67

jennifer-shehane opened this issue Sep 12, 2017 · 1 comment

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Sep 12, 2017

This commit seems to have broken the css in the https://docs-staging.cypress.io page. 5be5de4

See the Cypress Test Video of the run, where the css is obviously not loading correctly: https://dashboard.cypress.io/#/projects/ma3dkn/runs/c28f9d36-1eef-4bcf-b4fb-8e9a4732ac4f/videos

And the Cypress Test Video on the commit before, where the css is fine: https://dashboard.cypress.io/#/projects/ma3dkn/runs/480835eb-3b6b-490d-a7c7-259a1275820c/videos

We need to:

  1. Fix the bug
  2. Write a test that ensures css is compiling and loading correctly after the deployment job on CI.

Can recreate locally running NODE_ENV=staging npm start. Ensure you are on Node 8 and have run npm i first.

@bahmutov
Copy link
Contributor

When style.css is bundled correctly it will have rules for things like `#container', which makes it height 100% of the viewport

screen shot 2017-09-12 at 2 29 02 pm

we can do two tests:

  • make sure the container height is equal to viewport height
  • loaded document CSS rules have rules for #container element

bahmutov added a commit that referenced this issue Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants