Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BROWSERS_IMAGE_SHORT_TAG #1256

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Nov 24, 2024

Issue

The BROWSERS_IMAGE_TAG used for the cypress/browsers Docker image in the form

node-<NODE_VERSION>-chrome-<CHROME_VERSION>-ff-<FIREFOX_VERSION>-edge-<EDGE_VERSION>

for example

cypress/browsers:node-22.11.0-chrome-131.0.6778.69-1-ff-132.0.2-edge-131.0.2903.51-1

is not supported by the Renovate Docker update function, since it does not look like a simple version tag. The tag is also inconveniently long when shown in examples and documentation.

Other Cypress Docker images, intended for external use, each have a Renovate-Docker compatible tag.

Repo name Tag name Renovate-Docker compatible Example
cypress/factory FACTORY_VERSION yes 5.1.0
cypress/base BASE_IMAGE_TAG yes 22.11.0
cypress/included INCLUDED_IMAGE_SHORT_TAG yes 13.16.0

cypress/browsers is currently missing a Renovate-Docker-compatible tag.

Change

A new tag BROWSERS_IMAGE_SHORT_TAG is added to cypress/browsers with the form

NODE_VERSION

for example

cypress/browsers:22.11.0.

The existing tag BROWSERS_IMAGE_TAG remains as the main immutable tag for cypress/browsers images.

Release is split into two PRs. This one is the first and it implements the tag BROWSERS_IMAGE_SHORT_TAG in preparation for the next Node.js or browser version update.

A follow-on PR will provide documentation once the tag is actually available since the documentation needs to refer to concrete released versions, which are as yet undefined.

Verification

cd factory
docker compose build factory
docker compose build browsers --no-cache
docker image list cypress/browsers*

Confirm the presence of a cypress/browsers image with a BROWSERS_IMAGE_SHORT_TAG such as 22.11.0.

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator Author

There is no problem to use BROWSERS_IMAGE_SHORT_TAG with a non-primary Node.js version, for instance if a set of Cypress Docker images for the current Node.js version v23.3.0 were to be deployed, then there should be two new tags created:

  • cypress/browsers:23.3.0
  • cypress/browsers:node-23.3.0-chrome-131.0.6778.69-1-ff-132.0.2-edge-131.0.2903.51-1

Only the use of the latest tag with cypress/browsers:latest for this new image should be suppressed. It should remain used with cypress/browsers:node-22.11.0-chrome-131.0.6778.69-1-ff-132.0.2-edge-131.0.2903.51-1.

Modified in b0c0841

Update
- CHROME_VERSION to 131.0.6778.85-1
- EDGE_VERSION to 131.0.2903.70-1
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Nov 26, 2024

The next planned full version releases of Chromium browsers is not until Jan 2025, so updating browsers to latest current patch versions to trigger creation of BROWSERS_IMAGE_SHORT_TAG tag.

Update

  • CHROME_VERSION from 131.0.6778.69-1 to 131.0.6778.85-1
  • EDGE_VERSION from 131.0.2903.51-1 to 131.0.2903.70-1

@MikeMcC399 MikeMcC399 marked this pull request as ready for review November 26, 2024 08:51
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. Will be looking out for part 2

@AtofStryker AtofStryker merged commit 3f88465 into cypress-io:master Nov 26, 2024
31 checks passed
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Nov 26, 2024

@AtofStryker

makes sense.

Thanks for your approval! 🙂

Will be looking out for part 2

Docker Hub repo cypress/browsers shows the short-form image tag is now published:

docker pull cypress/browsers:22.11.0

@MikeMcC399 MikeMcC399 deleted the add/browsers-short-tag branch November 26, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants