Option to always allow external images

[mercihabam]

Description

show the list of all external resources in an email and allow the user to approve each one individually or all at once or approve all resources from the sender.

Issues

• Option to always allow external images #861

[kroky]

Why do we want to keep the exceptions in a set of cookies? Might be too much information for the cookie storage - imagine people allowing all external resources in many emails one after the other. Instead, can't we do it all in JS on client-side?

E.g. server-side continues to replace src attributes but also adds data-source, so JS code can access the original sources. It can also add the proper allow/allow all links but then JS handlers will actually execute, replace img tags with actual sources and allow the display if user clicks the action buttons/links.

[mercihabam]

Why do we want to keep the exceptions in a set of cookies? Might be too much information for the cookie storage - imagine people allowing all external resources in many emails one after the other. Instead, can't we do it all in JS on client-side?

E.g. server-side continues to replace src attributes but also adds data-source, so JS code can access the original sources. It can also add the proper allow/allow all links but then JS handlers will actually execute, replace img tags with actual sources and allow the display if user clicks the action buttons/links.

What you're suggesting is valid, but then, it would require the user to always perform that action of allowing external images whenever they open the same email and want to visualize images because we are not storing the state anywhere. I think the purpose is to make it easy for the user so they don't repeat the same action always, we are even planning to add another option that will allow the user to always display images from a certain sender.
What do you think @kroky?

[kroky]

Can we use local storage or session storage much like other cypht code use it in that case?

[mercihabam]

Can we use local storage or session storage much like other cypht code use it in that case?

Ok, let's explore that way.