Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHPUnit from 9 to 10 #1044

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Upgrade PHPUnit from 9 to 10 #1044

merged 5 commits into from
Jun 5, 2024

Conversation

Shadow243
Copy link
Member

@marclaporte
Copy link
Member

Please continue working on this, but wait a bit before merging in.

I'd like https://hub.docker.com/r/cypht/cypht to be operational ASAP.

@Shadow243
Copy link
Member Author

Please continue working on this, but wait a bit before merging in.

I'd like https://hub.docker.com/r/cypht/cypht to be operational ASAP.

This one is ready to be reviewed.

@marclaporte marclaporte mentioned this pull request May 25, 2024
@Shadow243
Copy link
Member Author

I'm separating tests to prevent the non-execution of some, like here:

 php vendor/bin/phpunit --bootstrap vendor/autoload.php --configuration tests/phpunit/phpunit.xml --testdox --filter=Hm_Test_Modules_Output
PHPUnit 10.5.20 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.28
Configuration: /Users/shadow243/software/www/TIKI/cypht/tests/phpunit/phpunit.xml

No tests executed!

@Shadow243 Shadow243 marked this pull request as ready for review May 30, 2024 11:15
@Shadow243
Copy link
Member Author

I'm separating tests to prevent the non-execution of some, like here:

 php vendor/bin/phpunit --bootstrap vendor/autoload.php --configuration tests/phpunit/phpunit.xml --testdox --filter=Hm_Test_Modules_Output
PHPUnit 10.5.20 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.28
Configuration: /Users/shadow243/software/www/TIKI/cypht/tests/phpunit/phpunit.xml

No tests executed!

Done.

@josaphatim
Copy link
Member

josaphatim commented Jun 3, 2024

@Shadow243 Look at the picture below. This is the output I'm getting. Can you just fix The configuration file did not pass validation! warning and make sure user unittestuser already exists pass correctly please ? Thanks.

Screenshot 2024-06-03 at 02 59 40

@Shadow243
Copy link
Member Author

Shadow243 commented Jun 3, 2024

You still have phpunit 9.x you should have 10.5.x instead. Just look at the first line on the same picture.

@josaphatim
Copy link
Member

You are right! But I'm still getting almost same thing. Instead I realize that there are now 296 tests instead of 379 and 710 assertions instead of 852.

Screenshot 2024-06-03 at 05 04 21

@Shadow243
Copy link
Member Author

Shadow243 commented Jun 3, 2024

assertions
Please compare with this list and not the number of tests and assertions.

Screenshot 2024-06-03 at 07 33 25

As you can see the same config file is showing 379 with phpunit9 and 296 with phpunit10.

@Shadow243
Copy link
Member Author

Rename phpunit/modules/core/modules.php to make other tests availlable

Other tests renamed: 5825aa1

@Shadow243 Shadow243 force-pushed the phpunit-10 branch 3 times, most recently from 630e16e to 6349ce8 Compare June 3, 2024 10:01
@josaphatim
Copy link
Member

@kroky now looks good to me. Can you check please ?

@kroky kroky merged commit a5832e8 into cypht-org:master Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants