Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external resources handling for inline message style #1002

Merged
merged 1 commit into from
May 7, 2024

Conversation

mercihabam
Copy link
Member

@marclaporte marclaporte requested a review from kroky May 5, 2024 21:28
@kroky kroky merged commit 117f04b into cypht-org:master May 7, 2024
4 of 5 checks passed
@PaulTGG
Copy link
Contributor

PaulTGG commented May 8, 2024

In order for this PR to work on inline messages, you first have to open a message individually, and not in inline view. Then the added controls will show up in the inline view for that particular message. They don't show up by default.

@mercihabam
Copy link
Member Author

In order for this PR to work on inline messages, you first have to open a message individually, and not in inline view. Then the added controls will show up in the inline view for that particular message. They don't show up by default.

I agree with you @PaulTGG. #1014 addresses the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants