mkdir: do not error out with -EEXIST for racing MkdirAlls #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
racing-mkdir-eexist
branch
2 times, most recently
from
a89da1f to
5d700de
Compare
cyphar
changed the title
If two programs are doing MkdirAll, the previous logic would return an error if a directory already existed once we got into the "mkdir" portion of the creation. Since we already have to accept that an attacker can swap the inode with a different directory, returning -EEXIST from mkdirat(2) just causes spurious errors. All we care about is that we open a directory. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
racing-mkdir-eexist
branch
from
5d700de to
ef8c3b4
Compare
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
racing-mkdir-eexist
branch
from
ef8c3b4 to
31cb517
Compare
This was referenced Dec 6, 2024
|
Sorry, probably should've waited for a review before merging + releasing. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two programs are doing MkdirAll, the previous logic would return an
error if a directory already existed once we got into the "mkdir"
portion of the creation.
Since we already have to accept that an attacker can swap the inode with
a different directory, returning -EEXIST from mkdirat(2) just causes
spurrious errors. All we care about is that we open a directory.
Ref: opencontainers/runc#4543
Ref: moby/buildkit#5566
Signed-off-by: Aleksa Sarai [email protected]