Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cylc play service #525

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Fix cylc play service #525

merged 5 commits into from
Nov 24, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Nov 20, 2023 •
edited
Loading

  • cylc version arg was not working
  • could not play multiple workflows

Closes #524

Should we backport this to 1.3.x?

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie
Fix cylc play service
cd6b6fa 
- cylc version arg was not working
- could not play multiple workflows
@MetRonnie MetRonnie added the bug Something isn't working label Nov 20, 2023
@MetRonnie MetRonnie added this to the 1.4.2 milestone Nov 20, 2023
@MetRonnie MetRonnie self-assigned this Nov 20, 2023
@MetRonnie MetRonnie changed the title Fix cylc play service: Fix cylc play service Nov 21, 2023
@MetRonnie
cylc play service: do not exit early on failure
01a2da6 
Try to play all specified workflows and return all statuses at end
@MetRonnie
Changelog
991fc69
@MetRonnie
Mypy: exclude tests
9fd0e3e
oliver-sanders
oliver-sanders approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved
@wxtim
Copy link
Member

wxtim commented Nov 24, 2023

Will merge after doing a little due diligence on failing test.

@wxtim wxtim merged commit c3e3a55 into cylc:1.4.x Nov 24, 2023
3 of 5 checks passed
@MetRonnie MetRonnie deleted the cylc-play branch November 24, 2023 11:16
@MetRonnie MetRonnie linked an issue Nov 27, 2023 that may be closed by this pull request
Unable to set CYLC_VERSION in web UI for Play #524
Closed
@MetRonnie MetRonnie mentioned this pull request Dec 1, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

Unable to set CYLC_VERSION in web UI for Play
3 participants
@MetRonnie @wxtim @oliver-sanders