Pass authenticated user to cylc-flow #288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 77.48% 77.40% -0.08%
==========================================
Files 12 12
Lines 1008 1009 +1
Branches 176 176
==========================================
Hits 781 781
- Misses 196 197 +1
Partials 31 31
Continue to review full report at Codecov.
|
datamel
force-pushed
the
pass-username-to-cylc-flow
branch
from
62f1f22 to
436dd86
Compare
|
Note test failure expected as it requires sibling cylc-flow to be checked out.
Ah, tests will only pass if checked out with sibling on cylc-flow. |
|
I can confirm that tests pass if Sibling PR is checked out. I will leave you to merge this and the sibling at the same time so as not to break master. |
datamel
force-pushed
the
pass-username-to-cylc-flow
branch
from
7dfc98b to
8bbf0ab
Compare
Remove unused code
datamel
force-pushed
the
pass-username-to-cylc-flow
branch
from
8bbf0ab to
27f9d79
Compare
| @@ -224,29 +227,3 @@ async def service(self, info, *m_args): | |||
| self.workflows_mgr, | |||
| log=self.log | |||
| ) | |||
|
|
|||
| async def nodes_mutator(self, info, *m_args): | |||
There was a problem hiding this comment.
@dwsutherland, any chance you could double check that this is unused code. I couldn't get any breakpoints stopping here, can't find any code calls. Both myself and @oliver-sanders think it is not used and should be removed? Also, removed its cylc-flow partner in https://github.com/cylc/cylc-flow/pull/4522/files.
There was a problem hiding this comment.
It was in use, until:
cylc/cylc-flow#3469
specifically:
https://github.com/cylc/cylc-flow/pull/3469/files#diff-97f4d62be41218e2d70a203edfca6d44d7c0046b6908cefa8e3af7c02cd31920
(it was called from the schema which is inherited here)
And the idea behind it was that mutations being multi-workflow could be given node ids from different workflows, and then these ids would be parsed and mutations sent to the appropriate workflow..
The fact that we moved away from this, means we are happy with not using this functionality... i.e. a node mutation will always be associated with only one workflow and/or the workflow parsing happens somewhere else.
This is necessary for logging which authenticated user executes the command on the UI.
Sibling pr: cylc/cylc-flow#4522
These changes close #224 and cylc/cylc-flow#4294
CONTRIBUTING.mdand added my name as a Code Contributor.