-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have authorise handle key errors when getting group names from ids #272
Conversation
9332242
to
7f2507f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, haven't manually tested, MyPy is unhappy for some reason.
c683dee
to
13a1218
Compare
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 77.62% 77.55% -0.07%
==========================================
Files 12 12
Lines 1001 1007 +6
Branches 173 175 +2
==========================================
+ Hits 777 781 +4
Misses 195 195
- Partials 29 31 +2
Continue to review full report at Codecov.
|
13a1218
to
7097548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have currently working groups so I can not manually check this. I have read the code and am happy with the logic. Thanks @wxtim, and good catch on the issue!
@datamel happy to merge? |
Worth saying that it seems to work for Dave. |
This is a small change with no associated Issue.
Description of issue:
I got
KeyError
fromcylc.uiserver.authorise.parse_group_ids
because my profile is messed up and keys I wanted were not available.Description of response
authorise.py
wasn't working, so modified theapp.py
to pass the logger object in.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.