-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests for workflow_mgr #161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
===========================================
+ Coverage 58.95% 73.95% +15.00%
===========================================
Files 6 6
Lines 480 480
Branches 79 79
===========================================
+ Hits 283 355 +72
+ Misses 192 108 -84
- Partials 5 17 +12
Continue to review full report at Codecov.
|
2e62004
to
554a579
Compare
554a579
to
333b64a
Compare
I think this was more of an exercise to understand the state changes in the UI Server. When writing tests, I normally focus on the To test the private functions, I tried to trigger the right state changes in I tried using fixtures, and avoiding duplication as much as possible, though there might be some better way of writing these tests and reduce even more the amount of code written for tests. Happy to take any feedback and improve it. Should improve a bit our coverage prior to the next release 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests passing 👍
This is a small change with no associated Issue.
Similar to #160 , but adding more tests for
workflow_mgr
. Still trying to understand how its methods work, quite interesting. Found already one pydoc error. So if I cannot understand how to write tests, at least this PR will fix that pydoc 😅Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.