aotf: fix mutations in workflow toolbar #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
workflow-service-mutate-async
branch
from
880a0bf
to
8c80475
Compare
MetRonnie
force-pushed
the
workflow-service-mutate-async
branch
from
8c80475
to
caf60ae
Compare
|
I have force-pushed a fix. I'm happy to get this one in and add tests in a separate PR |
MetRonnie
force-pushed
the
workflow-service-mutate-async
branch
from
caf60ae
to
14e4ede
Compare
MetRonnie
reviewed
Apr 29, 2022
| @@ -67,7 +67,6 @@ class WorkflowService { | |||
| this.subscriptions = {} | |||
|
|
|||
| // mutations defaults | |||
| this.associations = null | |||
There was a problem hiding this comment.
(This was never used since the commit that introduced it - e7a3fbe#diff-5bf28b4f8de7d141f3dbfe760f5d05effbfc83e4debf8859ebee820fc81bfa7bR209)
datamel
approved these changes
May 3, 2022
hjoliver
approved these changes
May 4, 2022
|
(Not easy to add tests now, as discussed). |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #998
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.