Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ghosts from graphql args #980

Merged
merged 1 commit into from
Apr 1, 2022
Merged

remove ghosts from graphql args #980

merged 1 commit into from
Apr 1, 2022

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Mar 31, 2022 •
edited by MetRonnie
Loading

These changes partially address cylc/cylc-uiserver#341

Sibling to cylc/cylc-flow#4791
(Can go in before sibling, UI master will be broken with sibling merged first)

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry needed (just removes unused code).
  • No documentation update required.

@dwsutherland dwsutherland added this to the 1.2.0 milestone Mar 31, 2022
@dwsutherland dwsutherland self-assigned this Mar 31, 2022
@dwsutherland dwsutherland mentioned this pull request Mar 31, 2022
Merged
7 tasks
@dwsutherland dwsutherland mentioned this pull request Mar 31, 2022
Closed
hjoliver
hjoliver approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log entry not needed as this just removes unused code.

@hjoliver hjoliver merged commit 0843cfe into cylc:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@dwsutherland dwsutherland

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dwsutherland @hjoliver