Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vuetify to 2.1, along with other dependencies with updates available #285

Merged
merged 10 commits into from
Oct 12, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Oct 11, 2019

These changes close #276

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why? library update).
  • Appropriate change log entry included.
  • No documentation update required.

@kinow kinow self-assigned this Oct 11, 2019
@kinow kinow added this to the 0.2 milestone Oct 11, 2019
@kinow kinow changed the title Update libraries Update Vuetify to 2.1 and other libraries with ncu Oct 11, 2019
@kinow kinow changed the title Update Vuetify to 2.1 and other libraries with ncu Update Vuetify to 2.1, along with other dependencies with updates available Oct 11, 2019
@kinow
Copy link
Member Author

kinow commented Oct 11, 2019

Looks pretty much the same to me.

image

Struggled a bit to fix the Header component style, and also cleaned up unused values for Header and Drawer.

@kinow
Copy link
Member Author

kinow commented Oct 11, 2019

List of what was updated:

$ ncu -u


   ╭──────────────────────────────────────────────╮
   │                                              │
   │      Update available 3.1.21 → 3.1.23        │
   │   Run npm i -g npm-check-updates to update   │
   │                                              │
   ╰──────────────────────────────────────────────╯

Upgrading /home/kinow/Development/python/workspace/cylc-ui/package.json
[====================] 50/50 100%

 graphql                       ^14.5.3  →  ^14.5.8 
 tippy.js                       ^4.3.5  →   ^5.0.2 
 vee-validate                   ^3.0.2  →  ^3.0.11 
 vue-i18n                      ^8.14.0  →  ^8.14.1 
 vue-meta                       ^2.2.1  →   ^2.3.1 
 vue-router                     ^3.1.2  →   ^3.1.3 
 vuetify                       ^2.0.10  →   ^2.1.3 
 @mdi/font                     ^4.1.95  →  ^4.5.95 
 @vue/cli-plugin-babel         ^3.11.0  →  ^3.12.0 
 @vue/cli-plugin-e2e-cypress   ^3.11.0  →  ^3.12.0 
 @vue/cli-plugin-eslint        ^3.11.0  →  ^3.12.0 
 @vue/cli-plugin-unit-mocha    ^3.11.0  →  ^3.12.0 
 @vue/cli-service              ^3.11.0  →  ^3.12.0 
 cross-env                      ^5.2.0  →   ^6.0.3 
 eslint                         ^6.2.2  →   ^6.5.1 
 sass                         ^1.22.10  →  ^1.23.0 
 sass-loader                    ^7.3.1  →   ^8.0.0 
 sinon                          ^7.4.1  →   ^7.5.0 
 standard                      ^14.0.2  →  ^14.3.1 
 vue-cli-plugin-apollo         ^0.21.0  →  ^0.21.1 
 vuetify-loader                 ^1.2.2  →   ^1.3.0 
 webpack                       ^4.39.2  →  ^4.41.0 

Run npm install to install new versions.

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #285 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   66.66%   66.52%   -0.15%     
==========================================
  Files          17       17              
  Lines         231      230       -1     
==========================================
- Hits          154      153       -1     
  Misses         77       77
Impacted Files Coverage Δ
src/store/app.module.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe39885...59c77ba. Read the comment docs.

@kinow
Copy link
Member Author

kinow commented Oct 11, 2019

Funny, failing on npm run build, but that works on my computer. Bumped up to Node 10 LTS

image

But still no luck. Will take a look on Monday.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me. @kinow - you can decide if a second review is needed.

@hjoliver
Copy link
Member

(I missed your comment on npm run build failing - but it works fine in my environment).

@kinow
Copy link
Member Author

kinow commented Oct 12, 2019

The error appears to be ValidationError: Invalid options object. Sass Loader has been initialised using an options object that does not match the API schema., which would be: webpack-contrib/sass-loader#760

Related to this part of our updates:

sass-loader ^7.3.1 → ^8.0.0

image

@hjoliver successfully reproduced it after deleting my node_modules and dist folders, then re-running npm run build. Tricky issue.

Then, vue inspect | less and searching for "sass" revealed the origin of the issue.

image

Whew. At least now it appears to make sense why Travis - thankfully - failed. That may have saved us some issues pre/post next release.

Makes even more sense, I think, that vuetify-loader (used by Vuetify) creates projects with a webpack.config.js that uses that invalid data key: https://github.com/vuetifyjs/vuetify-loader/blob/3a6a2ffcfc4233dbfdd88d549d55e6cea79ef4fb/dev/webpack.config.js#L13

Sooo... easier to just downgrade sass-loader back to ^7.3.1 instead of trying to fight with this nasty bug. Will file an issue to vuetify-loader telling what happened, in case it helps somebody else 👍

@kinow
Copy link
Member Author

kinow commented Oct 12, 2019

I think one review is enough, tested again, all good with the commands on my environment, Travis happy as well. Merging, thanks!!! 🎉

@kinow kinow merged commit aeff0d0 into cylc:master Oct 12, 2019
@kinow kinow deleted the update-libraries branch October 12, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Vuetify 2.1
3 participants