-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vuetify to 2.1, along with other dependencies with updates available #285
Conversation
List of what was updated: $ ncu -u
╭──────────────────────────────────────────────╮
│ │
│ Update available 3.1.21 → 3.1.23 │
│ Run npm i -g npm-check-updates to update │
│ │
╰──────────────────────────────────────────────╯
Upgrading /home/kinow/Development/python/workspace/cylc-ui/package.json
[====================] 50/50 100%
graphql ^14.5.3 → ^14.5.8
tippy.js ^4.3.5 → ^5.0.2
vee-validate ^3.0.2 → ^3.0.11
vue-i18n ^8.14.0 → ^8.14.1
vue-meta ^2.2.1 → ^2.3.1
vue-router ^3.1.2 → ^3.1.3
vuetify ^2.0.10 → ^2.1.3
@mdi/font ^4.1.95 → ^4.5.95
@vue/cli-plugin-babel ^3.11.0 → ^3.12.0
@vue/cli-plugin-e2e-cypress ^3.11.0 → ^3.12.0
@vue/cli-plugin-eslint ^3.11.0 → ^3.12.0
@vue/cli-plugin-unit-mocha ^3.11.0 → ^3.12.0
@vue/cli-service ^3.11.0 → ^3.12.0
cross-env ^5.2.0 → ^6.0.3
eslint ^6.2.2 → ^6.5.1
sass ^1.22.10 → ^1.23.0
sass-loader ^7.3.1 → ^8.0.0
sinon ^7.4.1 → ^7.5.0
standard ^14.0.2 → ^14.3.1
vue-cli-plugin-apollo ^0.21.0 → ^0.21.1
vuetify-loader ^1.2.2 → ^1.3.0
webpack ^4.39.2 → ^4.41.0
Run npm install to install new versions. |
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 66.66% 66.52% -0.15%
==========================================
Files 17 17
Lines 231 230 -1
==========================================
- Hits 154 153 -1
Misses 77 77
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward to me. @kinow - you can decide if a second review is needed.
(I missed your comment on |
The error appears to be Related to this part of our updates:
@hjoliver successfully reproduced it after deleting my Then, Whew. At least now it appears to make sense why Travis - thankfully - failed. That may have saved us some issues pre/post next release. Makes even more sense, I think, that Sooo... easier to just downgrade |
I think one review is enough, tested again, all good with the commands on my environment, Travis happy as well. Merging, thanks!!! 🎉 |
These changes close #276
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.