Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check what the cutoff field in the broadcast form is doing #1222

Closed
MetRonnie opened this issue Feb 2, 2023 · 2 comments · Fixed by #1226
Closed

Check what the cutoff field in the broadcast form is doing #1222

MetRonnie opened this issue Feb 2, 2023 · 2 comments · Fixed by #1226
Assignees
@MetRonnie
Labels
investigation
Milestone
1.5.0

Comments

@MetRonnie
Copy link
Member

No description provided.

@MetRonnie MetRonnie added this to the 1.6.0 milestone Feb 2, 2023
@MetRonnie MetRonnie self-assigned this Feb 2, 2023
@MetRonnie MetRonnie changed the title Check what broadcast cutoff is doing Check what the cutoff field in the broadcast form is doing Feb 2, 2023
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 6, 2023
@oliver-sanders
schema: change type of broadcast cutoff field
d0088b8 
* The CyclePoint type was causing the UI to auto fill the cutoff field
  (because it likes to be helpful and autofills everything it can).
* However, that ain't helpful in this case, we wan't the cutoff blank.
* So changing back to a regular String for now.
* Closes cylc/cylc-ui#1222
@oliver-sanders
Copy link
Member

The "cutoff" field gets populated because AOTF tries to be helpful and fill in every field that it can. The cutoff field is a CyclePoint and AOTF knows the cycle point for the task you clicked on to open the broadcast menu...

We could just change the type of the field back to String, however, schema changes introduce compatibility issues. Older versions of the UIS would not support broadcasts to newer versions of cylc-flow and vice-versa.

This is exactly the sort of thing that AOTF was designed to avoid, however, at present we don't load the schema of each workflow individually, we load the schema of the UIServer so the UIS and workflow schemas must match. This should be addressed in future, it just hasn't been done yet, here's an issue to track this - #1225.

Until this is done, schema changes will break compatibility across UIServer versions.

oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Feb 6, 2023
@oliver-sanders
aotf: prevent the "offset" field from being filled in
4c14e57 
* Closes cylc#1222
* Note this solution is hardcoded in the UI and must stay that way
  until cylc#1225 is done.
@oliver-sanders oliver-sanders mentioned this issue Feb 6, 2023
Merged
6 tasks
@MetRonnie
Copy link
Member Author

Note: the cutoff field only applies to the "expire" mode

@MetRonnie MetRonnie modified the milestones: 1.6.0, 1.5.0 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MetRonnie MetRonnie

Labels
investigation
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

aotf: prevent the "offset" field from being filled in oliver-sanders/cylc-ui
2 participants
@oliver-sanders @MetRonnie