Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Changes to location of log/x/___-rose-suite.conf #137

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Small Changes to location of log/x/___-rose-suite.conf #137

merged 1 commit into from
Apr 8, 2022

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Apr 8, 2022 •
edited
Loading

Changes

  • dump rose-suite.conf in log/config not log/conf
  • ensure that log/config/-rose-suite.conf includes a time-zone

Admin

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to setup.cfg.
  • Already covered by existing tests.
  • Does not need tests (why?).
  • No change log entry required (Pre-release change to log dir, should be invisible to all but a few select test users).
  • No documentation update required.

@wxtim
- dump rose-suite.conf in log/config not log/conf
3a84fe8 
- ensure that log/config/<timestamp>-rose-suite.conf includes a time-zone
@wxtim wxtim self-assigned this Apr 8, 2022
@wxtim wxtim requested a review from MetRonnie April 8, 2022 08:59
@wxtim wxtim added this to the 1.0.3 milestone Apr 8, 2022
@MetRonnie MetRonnie added the small label Apr 8, 2022
@MetRonnie MetRonnie merged commit cf7e783 into cylc:master Apr 8, 2022
@wxtim wxtim deleted the move_log/conf/<timestamp>-rose-suite.conf_to_log/config_and_add_tz_to_timestamp branch April 8, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Tidy Log Directory
2 participants
@wxtim @MetRonnie