Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify SLURM job handler docs #5748

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Sep 29, 2023

Clarify the formats permitted for directives to SLURM.

Record investigations:

# part of a flow.cylc file
[[[directives]]]
  -H               # Fails Cylc validation
  -H=              # Works
  --hold           # Fails Cylc validation
  --hold=          # Holds your SLURM job as you'd hope
  -b now+60        # Fails Cylc validation
  -b=now+60        # Sbatch fails with invalid options
  -b now+60=       # Sbatch ... just no
  --begin=now+60   # Works

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • This is a documentation change only: I have built the documentation locally.

@wxtim wxtim self-assigned this Sep 29, 2023
@wxtim wxtim added the doc Documentation label Sep 29, 2023
@wxtim wxtim added this to the cylc-8.2.2 milestone Sep 29, 2023
@wxtim wxtim changed the base branch from master to 8.2.x September 29, 2023 14:13
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.2, cylc-8.2.3 Oct 4, 2023
@wxtim wxtim force-pushed the fix.confusing_note_about_directives branch from 674502f to c2a5481 Compare October 9, 2023 10:07
@wxtim wxtim requested a review from oliver-sanders October 9, 2023 10:08
@wxtim wxtim requested a review from oliver-sanders October 10, 2023 13:54
@oliver-sanders oliver-sanders merged commit 522dc98 into cylc:8.2.x Oct 11, 2023
25 checks passed
wxtim added a commit to wxtim/cylc that referenced this pull request Oct 18, 2023
* upstream/master:
  speed up import time (cylc#5770)
  graphql: remove extraLogs field (cylc#5672)
  give a more useful error message if remote init fails (cylc#5720)
  clarify SLURM job handler docs (cylc#5748)
@wxtim wxtim deleted the fix.confusing_note_about_directives branch March 18, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants