Cut down on back-compat warnings, plus other tidying #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The ones that should be replaced by platform)
MetRonnie
commented
Jun 29, 2022
Comment on lines
-354
to
-358
| REG_CLASH_MSG = ( | ||
| "The specified reg could refer to ./{0} or ~/cylc-run/{1}. " | ||
| "This command will use ./{0}." | ||
| ) | ||
|
|
There was a problem hiding this comment.
(This was no longer used)
hjoliver
approved these changes
Jun 30, 2022
Do not suggest using `allow implicit tasks` setting when rose-suite.conf present in c7 back-compat mode
oliver-sanders
approved these changes
Jun 30, 2022
7 tasks
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Jul 4, 2022
* master: (30 commits) Log dir tidy (cylc#4836) Cut down on back-compat warnings, plus other tidying (cylc#4943) Validate platform settings (background job runner) (cylc#4938) clean: push error message to stderr Update cylc/flow/id_match.py Fix unintended directory stripping during cylc install (cylc#4931) stop cylc validate swallowing useful errors (cylc#4936) Improve config reference docs (cylc#4916) glblcfg: increase default rolling archive length Fix job state with pre-submitted failure Update tests/functional/cylc-reinstall/02-failures.t reinstall: require workflow ID argument play: upgrade --start-task's specified in legacy format (cylc#4925) expand schema docstring internally (cylc#4926) Added a new task filtering test. Add comment [skip ci] Fix optparse Options class for std options (cylc#4919) uid: warn if the run number is provided as a cycle Tweak prev. Fix task filtering. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify graph back compat warning and include link to docsCut down on back compat warnings, on the basis they're not actionable while in back compat modeTask foo: deprecated "host" and "batch system" use "platform"warning with something cleareriso8601.pycode comments (and code?) #4805Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.