Tidy & homogenise usage of CylcOptionParser
#4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
force-pushed
the
opt-parse-refactor
branch
2 times, most recently
from
74dcbe6
to
0bb5441
Compare
👍 I just started making near-identical changes while looking at #4810, but fortunately saw this PR in time 😁 |
|
I have actually had this branch going for months, good thing I finally got round to opening a PR for it 😅 |
datamel
approved these changes
Apr 13, 2022
Comment on lines
+491
to
+495
| @staticmethod | ||
| def optional(arg: Tuple[str, str]) -> Tuple[str, str]: | ||
| """Make an argdoc tuple display as an optional arg with | ||
| square brackets.""" | ||
| name, doc = arg | ||
| return (f'[{name}]', doc) |
There was a problem hiding this comment.
Not sure this is actually helpful but don't mind it that much.
MetRonnie
force-pushed
the
opt-parse-refactor
branch
2 times, most recently
from
b88c079
to
8e1c103
Compare
- Centralise common ID arg (name, description) tuples - Add docstring to CylcOptionParser `__init__()` - Remove CylcOptionParser's 'prep' argument
MetRonnie
force-pushed
the
opt-parse-refactor
branch
from
8e1c103
to
5e73a64
Compare
Sorry, I didn't see this comment before merging that PR. |
hjoliver
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CylcOptionParser.__init__()CylcOptionParser'sprepargumentThis is a small change with no associated Issue. But would be a useful thing to get in before #4676
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.