config: more helpful error message on cli misuse #2974
Conversation
|
|
||
| def __str__(self): | ||
| return repr(self.msg) |
There was a problem hiding this comment.
This will probably break the test battery, if we are happy with this approach (removing the repr logic) I'll go through and fix any failures.
There was a problem hiding this comment.
It broke everything last time I tried this. Good luck! 😉
|
|
||
| def __str__(self): | ||
| return repr(self.msg) |
There was a problem hiding this comment.
It broke everything last time I tried this. Good luck! 😉
|
Oh, actually looking at Travis now before merging... if it's failing due to one of those flaky tests, I'll kick it a few times. |
@oliver-sanders you got two 👍 here, and I just kicked Travis (just in case) but looks like it was as you suggested, and the test battery is now broken. If you could fix it, then I think this will be ready to be merged. |
oliver-sanders
force-pushed
the
cylc-run-invalid-cycle-point-conflicting-syntax
branch
from
501bcae
to
c21bf37
Compare
|
Now conflicted! |
|
Have changed the base to 7.8.x, will address this on master in #2982. |
oliver-sanders
force-pushed
the
cylc-run-invalid-cycle-point-conflicting-syntax
branch
2 times, most recently
from
a6b8f76
to
c7b3249
Compare
oliver-sanders
force-pushed
the
cylc-run-invalid-cycle-point-conflicting-syntax
branch
from
c7b3249
to
6472d9b
Compare
|
Re-approve after re-base. @kinow please perform similar sanity check and merge. |
|
Looks good to me, merging! |
oliver-sanders
deleted the
cylc-run-invalid-cycle-point-conflicting-syntax
branch
Response to user request for more informative feedback in the event that a user misses a
-sflag when attempting to run a non-cycling suite e.g:It's difficult to provide suggestive feedback as it is not clear what the user's intent was. Also there are other ways we could end up with a malformed
=separated pair on the CLI.$ cylc run mysuite mode=simulation