Give logger a null handler on start up #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should revisit logging as part of the 2to3 effort (or soon after) and have a better strategy. |
|
The formatting of the help screen of some commands changed, but only really small changes, which are OK IMO. e.g.
Before the change, the
|
So, cylc logger will always have a handler. CylcOptionParser will ensure that commands will have a valid logging handler. Scheduler will do likewise for daemonized suites. Use CylcOptionParser for all remaining user commands: * cylc cycle-point * cylc documentation * cylc get-gui-config * cylc get-site-config This ensures that these commands will have logging handlers set.
matthewrmshin
force-pushed
the
fix-no-logging-handler
branch
from
0c47441
to
59caceb
Compare
|
(Sorry, just re-based.) I have also added a compatibility check - as Python <2.7 does not have |
|
Not a problem, just one line change with the new |
oliver-sanders
approved these changes
Feb 7, 2019
|
Sorry I didn't refresh this page before merging so missed your comments, feel free to revert. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, cylc logger will always have a handler. CylcOptionParser will ensure
that commands will have a valid logging handler. Scheduler will do
likewise for daemonized suites.
Use CylcOptionParser for all remaining user commands:
This ensures that these commands will have logging handlers set.
Fix #2940.