Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo the User Guide Reflow section. #427

Merged
merged 9 commits into from
Apr 13, 2022

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Mar 16, 2022

To be merged AFTER cylc/cylc-flow#4738 and cylc/cylc-flow#4739

I spent a fair amount of time trying to edit this down to something simple and clear but recent history shows it is difficult to describe this stuff in universally agreed terms, so I won't bother adding extra cross-referencing etc. just yet. [it seems we have largely agreed].

Note this re-does the original Reflow section, which is now (well, about to be) out of date. In addition to this we may need, earlier in the guide, something on plain old triggering that mainly describes the default case, but refers forward to this Multiple Flows section for the full story.

@hjoliver
Copy link
Member Author

(Last update re-orders the somewhat randomly order of sub-sections in UG "Running Workflows")

src/glossary.rst Outdated Show resolved Hide resolved
src/glossary.rst Outdated Show resolved Hide resolved
@hjoliver
Copy link
Member Author

@dpmatthews - for some reason the GH UI has duplicated all of your comments, so I resolved one of each.

@hjoliver
Copy link
Member Author

Comments address; rebased and deconflicted.

Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got docs building in my system again.

Checked changes against browser results.. Looks good to me 👍

Copy link
Contributor

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@oliver-sanders oliver-sanders merged commit 02dc953 into cylc:master Apr 13, 2022
@hjoliver hjoliver deleted the redoc-reflow branch April 13, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants