Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should skip loading models that is loaded before #335

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: should skip loading models that is loaded before #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/realm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ async function loadModels(Spine, models, opts) {
const columns = schemaInfo[model.physicTable] || schemaInfo[model.table];
if (!model.attributes) initAttributes(model, columns);
model.load(columns);
Spine.models[model.name] = model;
cyjake marked this conversation as resolved.
Show resolved Hide resolved
}

for (const model of models) {
Expand Down Expand Up @@ -158,8 +157,9 @@ class Realm {
models = Object.values(this.models);
}

for (const model of models) this.Bone.models[model.name] = model;
// models could be connected already if cached
models = models.filter(model => !model.synchronized);
models = models.filter(model => model.synchronized == null);

if (models.length > 0) {
await loadModels(this.Bone, models, this.options);
Expand Down