fix: projects might have strictPropertyInitialization set to true #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
force-pushed
the
fix-usage-with-strict-property-init
branch
from
701dc67
to
0387c47
Compare
cyjake
commented
Aug 24, 2022
| @@ -25,18 +25,9 @@ export interface AbstractDataType<T> { | |||
| */ | |||
|
|
|||
| export abstract class DataType { | |||
| dataType: string; | |||
| dataType: string = ''; | |||
There was a problem hiding this comment.
compilerOptions.strictPropertyInitialization complains about unset class field
There was a problem hiding this comment.
which is quite common in our test models, such as
class Foo extends Bone {
@Column()
id: bigint;
}added a default value to make downstream projects happy for now
cyjake
commented
Aug 24, 2022
| * @returns {boolean} | ||
| */ | ||
| static is(params: any): boolean { | ||
| return params instanceof DataType; |
There was a problem hiding this comment.
further refactor the default export class DataTypes and the base class DataType, which can be imported as import DataTypes, { DataType } from './data_types';
existing code that relies on const { DataTypes } = require('./data_types') is changed to const { default: DataTypes } = require('./data_types') accordingly
JimmyDaddy
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att