feat: add leoric_bone meta data to Bone #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
reviewed
Jul 20, 2022
index.js
Outdated
| @@ -14,6 +14,7 @@ const Realm = require('./src/realm'); | |||
| const Decorators = require('./src/decorators'); | |||
| const Raw = require('./src/raw'); | |||
| const { MysqlDriver, PostgresDriver, SqliteDriver, AbstractDriver } = require('./src/drivers'); | |||
| const { isLeoricBone } = require('./src/utils'); | |||
There was a problem hiding this comment.
can we change this to isBone()? The Leoric part in the function name seems unnecessary.
JimmyDaddy
force-pushed
the
feat/add_leoric_bone_metadata
branch
from
80df604
to
f7e8125
Compare
cyjake
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/eggjs/egg-orm/blob/7086680f533b9efa70db55e06345adbb5ac321f5/lib/loader.js#L46
model class could be multiple inheritance,
OriginModelClass.prototype instanceof Modelcannot be a proper way to validate a model is a leoric bone