Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types for realm #278

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Conversation

luckydrq
Copy link
Contributor

@luckydrq luckydrq commented Feb 20, 2022

  • Make the last two parameters optional of Realm.prototype.define().
  • Add sync method signature.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #278 (c7522dd) into master (8d98cc0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          44       44           
  Lines        3204     3207    +3     
=======================================
+ Hits         3123     3126    +3     
  Misses         81       81           
Impacted Files Coverage Δ
src/drivers/abstract/spellbook.js 96.61% <0.00%> (ø)
src/bone.js 97.98% <0.00%> (+<0.01%) ⬆️
src/drivers/mysql/spellbook.js 97.61% <0.00%> (+0.05%) ⬆️
src/drivers/abstract/attribute.js 95.45% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d98cc0...c7522dd. Read the comment docs.

@@ -593,7 +593,7 @@ export class Bone {
toObject(): InstanceValues<this>;
}

interface ConnectOptions {
export interface ConnectOptions {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to port it to egg-orm

test/start.sh Outdated Show resolved Hide resolved
@cyjake cyjake merged commit a003599 into cyjake:master Feb 22, 2022
@luckydrq luckydrq deleted the add-types-for-realm branch February 22, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants