Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Cygwin Time Machine #4

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

me-and
Copy link
Contributor

@me-and me-and commented Mar 11, 2022

Using the Cygwin Time Machine requires (a) being able to specify the
mirror that's used for installing Cygwin, and (b) being able to disable
the signature checks the installer performs. Add options that allow
that, tests to check it works as expected, and documentation for the new
options.

Using the Cygwin Time Machine requires (a) being able to specify the
mirror that's used for installing Cygwin, and (b) being able to disable
the signature checks the installer performs.  Add options that allow
that, tests to check it works as expected, and documentation for the new
options.
@jon-turney
Copy link
Member

Thanks.

I assume you have a use for this?

My one concern is that setup can handle multiple --site options, specifying different package repositories. We don't need to handle that right now, but I'd like to understand how the site parameter could handle multiple URLs being specified.

@me-and
Copy link
Contributor Author

me-and commented Mar 13, 2022

Yep: my use case was wanting to do some Git builds with some old Cygwin packages, in the name of checking whether a regression was due to a change in the Git code or in one of the packaged Cygwin dependencies. Obviously it can be used to specify any mirror, not just a Time Machine one; I guess someone doing something unusual might want to use their own set of packages from their own mirror...

I'd forgotten it was possible to specify multiple mirrors, but I think that should be fine to handle. It looks like GitHub Actions doesn't allow a parameter to be anything other than a string, but I see no reason this couldn't be extended to accept multiple URLs with some separator (newlines seem the obvious choice, and is what I've seen other actions do, e.g. the path parameter for @actions/upload-artifact). There would just need to be some straightforward string wrangling to convert the input format to however setup.exe expects things, but this action is already doing similar wrangling with the packages parameter.

@jon-turney jon-turney merged commit 49f298a into cygwin:master Mar 14, 2022
@jon-turney
Copy link
Member

Thanks.

I created a v2 tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants