Skip to content

Commit

Permalink
Expire python34 left-overs
Browse files Browse the repository at this point in the history
  • Loading branch information
jon-turney committed Mar 31, 2024
1 parent 27a2ad8 commit 886e9b7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
7 changes: 3 additions & 4 deletions calm/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -1636,10 +1636,9 @@ def mark_fn(packages, po, v, certain_age, vault_requests):
# - if package depends on anything in expired_provides
#
requires = po.version_hints[v].get('depends', '').split(', ')
if re.match(r'^python(|2|27)[-_]', pn):
if any(ep in requires for ep in past_mistakes.expired_provides) or po.obsolete:
logging.debug("package '%s' version '%s' not retained as it requires a provide known to be expired" % (pn, v))
return Freshness.stale
if any(ep in requires for ep in past_mistakes.expired_provides):
logging.debug("package '%s' version '%s' not retained as it requires a provide known to be expired" % (pn, v))
return Freshness.conditional

# - explicitly marked as 'noretain'
#
Expand Down
3 changes: 1 addition & 2 deletions calm/past_mistakes.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,7 @@

# provides: which don't exist and packages which require them should be expired
expired_provides = [
'python2',
'python27',
'python34',
]

# empty source packages
Expand Down

0 comments on commit 886e9b7

Please sign in to comment.