Generalize the use of constant time ecdh::shared_secret_point #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `PublicKey` struct makes more sense for an api like this I think. If people want to access the internaly byte array, they can use the `PublicKey` serialize functions.
|
ACK, I think it makes sense and in case we need the full pubkey as byte array. I propose a small improvement: since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build up on 629ca80 that removes the use of
mul_tweak()and display 2 distinctscalculate_shared_point()api inutils, one for sending and the other for receiving. While very similar I think that it will help implementors figure out what argument goes where when you're either on receiver or sender side.