-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust-bitcoin utility functions #83
base: master
Are you sure you want to change the base?
Conversation
3afaeba
to
34adb75
Compare
34adb75
to
c713442
Compare
71e56e8
to
98ebbe3
Compare
The commits itself looks fine, but my concern is more about the trade-off of adding a (big) dependency that breaks all the time for the added convenience, compared to the original approach of keeping it out of rust-silentpayment and let downstream consumers (like sp-backend) deal with it. I think it's a bit premature now, and maybe we can talk about it again when sp-backend and donation wallet stabilize. |
i'm wondering if it is a way to supply util as macros instead functions, where the consumer can supply it's own bitcoin dependency? |
That sounds like it could work indeed, I'll check it out when I have the time |
That sounds great, but needs more investigation, I'm not super confortable with writing macros atm |
No description provided.