-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Sp Wallet #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygnet3
force-pushed
the
refactor-spwallet
branch
6 times, most recently
from
September 21, 2024 14:34
b7aca26
to
04fc055
Compare
cygnet3
force-pushed
the
refactor-spwallet
branch
from
September 24, 2024 18:31
f6bff91
to
6960a55
Compare
cygnet3
force-pushed
the
refactor-spwallet
branch
from
September 24, 2024 18:36
6960a55
to
2303803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built around the changes from cygnet3/sp-client#46. Most of the logic is the same, but it has been refactored, and a lot has been moved to the sp-client library. For a better overview of all the changes, see cygnet3/sp-client#46.