-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testの準備 #11
testの準備 #11
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
========================================
Coverage ? 87.5%
========================================
Files ? 1
Lines ? 16
Branches ? 2
========================================
Hits ? 14
Misses ? 2
Partials ? 0
Continue to review full report at Codecov.
|
query: undefined, | ||
mutation: LOGIN, | ||
variables: { email: '[email protected]', password: 'password' }, | ||
} as any); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typescriptの型情報が間違ってるっぽいので、とりあえずanyで突っ込んでます。(良い解決策求む)
apollographql/apollo-server#2172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ねえ、型って知ってる?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
別PRで対応
0409415
to
eb98579
Compare
// eslint-disable-next-line no-console | ||
console.log(`🚀 Server ready at localhost:${PORT}${server.graphqlPath}`); | ||
}); | ||
if (process.env.NODE_ENV !== 'test') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 fileを分けた時にこの分岐をなくす
query: undefined, | ||
mutation: LOGIN, | ||
variables: { email: '[email protected]', password: 'password' }, | ||
} as any); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ねえ、型って知ってる?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よいと思いまーす
close #5