Testts

[gidden]

built on top of #79 and #80, this looks at dbtypes.json.old in the cyclus repo (it requires cyclus/cyclus#1184). it should build and all tests should pass.

[gidden]

hi @opotowsky, takes a look at this PR to check against the old dbtypes

[opotowsky]

Oh, I feel very silly...I was changing the .json file name because I wasn't paying enough attention. Of course this passes now.

Question, though. As expected, the previous PRs are failing without the .old file. Should I merge them all in so this one can be reverted when we figure out the typsesytem bug in cymetric? But then I'm merging in failed builds...

[gidden]

These depend on cyclus/cyclus#1184, so that would need to be merged in
first. Then this branch should have its Travis run relaunched, as it would
be the only one expected to pass. It can then be pulled in to at least have
a minimally-working version in the near term.

I am not convinced that we actually need to support pre-release versions of
cymetric, so perhaps @scopatz can speak to that (if so, that should
probably be a listserv discusison). If needed, though, we can re-add the
old dbtypes.js to the website for one more release cycle and remove it
after that.

On Mon, Jun 15, 2015 at 12:05 PM, opotowsky [email protected]
wrote:

Oh, I feel very silly...I was changing the .json file name because I
wasn't paying enough attention. Of course this passes now.

Question, though. As expected, the previous PRs are failing without the
.old file. Should I merge them all in so this one can be reverted when we
figure out the typsesytem bug in cymetric? But then I'm merging in failed
builds...

—
Reply to this email directly or view it on GitHub
#81 (comment).

Matthew Gidden, Ph.D.
Postdoctoral Associate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph. 225.892.3192

[scopatz]

I am not convinced that we actually need to support pre-release versions of cymetric so perhaps @scopatz can speak to that

I would say no need for support for a couple of reasons. The first is that there was no promise of stability for cymetric until v1.3. The second is that there hadn't been any releases at all until then, so their was no promise of anything even being remotely backwards compatible.