-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More CI Updates #195
More CI Updates #195
Conversation
Build Status ReportBuild |
Expected failures of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of Q based on consistency?
@@ -40,7 +43,7 @@ jobs: | |||
uses: docker/login-action@v3 | |||
with: | |||
registry: ghcr.io | |||
username: ${{ github.repository_owner }} | |||
username: ${{ github.actor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it matter who we login as anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really since that workflow should be always be run from the cyclus repository. However, I think logging in as github.actor
is more transparent as far as what permissions exist (and the example in the action docs uses github.actor
)
Thanks @bennibbelink - let's give this a shot... |
After some discoveries made in cyclus #1667 some changes are necessary.
build_test.yml
doesnt push anything (including cache) to a package registry - this way a PR from a fork can perform testing with no issuespublish_latest.yml
is the ONLY workflow that updates theci-layer-cache
- this way any other workflow will be pulling layers fromcymetric:latest
some conversions of
repository_owner
toactor
incorporated PR trigger for
publish_release.yml
from Add PR trigger forpublish_release.yml
#192.Any workflows that publish an image (i.e.
publish_latest.yml
andpublish_release.yml
) should be modified from a branch on the upstream. This is consistent with our old strategychanged default cycamore tag to
latest
fromstable
in the Dockerfile. This serves two purposes: to ensure users are using the latest version of cycamore, and to help make upstream workflows less verbose