Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI Updates #195

Merged
merged 4 commits into from
Feb 15, 2024
Merged

More CI Updates #195

merged 4 commits into from
Feb 15, 2024

Conversation

bennibbelink
Copy link
Contributor

After some discoveries made in cyclus #1667 some changes are necessary.

  • build_test.yml doesnt push anything (including cache) to a package registry - this way a PR from a fork can perform testing with no issues

  • publish_latest.yml is the ONLY workflow that updates the ci-layer-cache - this way any other workflow will be pulling layers from cymetric:latest

  • some conversions of repository_owner to actor

  • incorporated PR trigger for publish_release.yml from Add PR trigger for publish_release.yml #192.

  • Any workflows that publish an image (i.e. publish_latest.yml and publish_release.yml) should be modified from a branch on the upstream. This is consistent with our old strategy

  • changed default cycamore tag to latest from stable in the Dockerfile. This serves two purposes: to ensure users are using the latest version of cycamore, and to help make upstream workflows less verbose

Copy link

Build Status Report

Build FROM cycamore_20.04_apt/cycamore:latest - Success
Build FROM cycamore_20.04_apt/cycamore:stable - Failure
Build FROM cycamore_20.04_conda/cycamore:latest - Success
Build FROM cycamore_20.04_conda/cycamore:stable - Failure
Build FROM cycamore_22.04_apt/cycamore:latest - Success
Build FROM cycamore_22.04_apt/cycamore:stable - Failure
Build FROM cycamore_22.04_conda/cycamore:latest - Success
Build FROM cycamore_22.04_conda/cycamore:stable - Failure

This was referenced Feb 14, 2024
@bennibbelink
Copy link
Contributor Author

Expected failures of publish_release.yml since cycamore:stable doesnt exist yet

@bennibbelink bennibbelink marked this pull request as ready for review February 14, 2024 17:18
@bennibbelink bennibbelink requested a review from gonuke February 14, 2024 23:51
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of Q based on consistency?

.github/workflows/publish_release.yml Outdated Show resolved Hide resolved
@@ -40,7 +43,7 @@ jobs:
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
username: ${{ github.actor }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter who we login as anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really since that workflow should be always be run from the cyclus repository. However, I think logging in as github.actor is more transparent as far as what permissions exist (and the example in the action docs uses github.actor)

@gonuke
Copy link
Member

gonuke commented Feb 15, 2024

Thanks @bennibbelink - let's give this a shot...

@gonuke gonuke merged commit f443378 into main Feb 15, 2024
14 of 18 checks passed
@bennibbelink bennibbelink deleted the ci-updates branch February 15, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants