-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cymetric CI #188
Update Cymetric CI #188
Conversation
bennibbelink
commented
Nov 29, 2023
- adds GitHub workflows and removes circleCI
- converts nosetests to pytest
- includes the changes from Fix pandas, collections, imp warnings #185
fad9e11
to
11b33ea
Compare
Also updated the README, |
When we eventually push a new cyclus python package, we should add it as a required dependency in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bennibbelink - this looks like a lot of tedious changes. There are a lot of strange whitespace changes, too.
Looks as though you may be changing some things as I review... but here are a few comments.
.github/workflows/build_test.yml
Outdated
|
||
- name: Build Cymetric | ||
run: | | ||
apt update && apt install -y python3-pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this depend on whether we are apt
or conda
? Or we should install it a dependency back when cyclus builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I added another step in the workflow. Eventually in cyclus we should use the python -m pip install
method to install cyclus instead of just calling setup.py
directly, so we will need pip as a dependency anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented this in a branch of cyclus that I have, along with some updates to the cmake build. I stumbled along some fixes while trying to get cython working, but I can make a separate PR for these general build changes
.github/workflows/changelog_test.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these days we should make this an action we can reuse across projects.
tests/test_fco_metrics.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more whitespace differences making this hard to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you click the settings icon you can choose to hide whitespace. This seems to work for me, it is easier to read changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I remembered that... but still confused by all the phantom whitespace changes.