Merging in minor misc bug fixes and the recipe reader #118
Conversation
| @@ -4,7 +4,6 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.Base64; | |||
| import java.util.Map; | |||
| import java.util.Optional; | |||
|
I have confirmed save/load now can resave |
|
hi @FlanFlanagan, it looks like the "number" box in the institution pane still has an issue. I now see the full render of "Add" when I open the box, but now the "number" field is too small to actually show anything. It also looks like the field may not be updating when you type, only when you click the add button? |
|
facility forms remember user level, nice! |
|
Hi @FlanFlanagan, I don't think the null commodity treatment is quite right (though I'm not sure the best way to fix it). What I see now is that when I choose "New Commodity", an empty entry pops up in the "Simulation Commodities" pane, but the choice on the facility archetype does not update if I write anything there. Again, I'm not sure exactly what should happen instead.. |
|
Hi @FlanFlanagan, since we're getting up very close to the wire, would it be possible to split this PR into different PRs based on which issue is being addressed? That way we can selectively update features that definitely work. Let me know if you'd like any guidance -- I'm happy to help. |
| @@ -108,6 +109,7 @@ public void replaceSelection(String text) { | |||
| } | |||
| } | |||
| }; | |||
| protoNumber.setMaxWidth(20); | |||
There was a problem hiding this comment.
I think this is too narrow. You can't see the number - probably needs to be at least 60.
|
@gidden - I'm not sure how easy it will be to untanggle this - may be better to push through. |
|
What if we push this branch as a feature branch to cyclus/cyclist2 and then we can collaborate on it with direct pushes to the branch, and a new PR |
|
replacing this with #122 for collaborative development |
|
This is good now @FlanFlanagan - merging. |
Merging in minor misc bug fixes and the recipe reader
Last one!