Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for lifetime on every facility at userlevel > 0 #110

Merged
merged 7 commits into from
Jun 7, 2015

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Jun 7, 2015

my first PR from 30,000 ft!

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

The only thing missing is that I don't test that it's an integer, which the schema probably expects?

@FlanFlanagan
Copy link
Member

Looks good Paul. We can probably add the integer check after? Or we can use my number only text field for this as well.

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

Can you point me to the number only text field?

@FlanFlanagan
Copy link
Member

I thought I extended the class but I guess not.

This code should do the trick when building the text field.

        TextField isoWeightFrac = new TextField(){
            @Override public void replaceText(int start, int end, String text) {
                if (!text.matches("[a-z]")){
                    super.replaceText(start, end, text);
                }
            }

            public void replaceSelection(String text) {
                if (!text.matches("[a-z]")){
                    super.replaceSelection(text);
                }
            }
        };

@FlanFlanagan
Copy link
Member

sorry that bottom bit of code is superfluous. Just need

    TextField isoWeightFrac = new TextField(){
        @Override public void replaceText(int start, int end, String text) {
            if (!text.matches("[a-z]")){
                super.replaceText(start, end, text);
            }
        }
    };

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

hold on whitespace....

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

whitespace updated...

@FlanFlanagan
Copy link
Member

Is this ready paul?

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

one sec... switching to context menus as part of this

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

ready now

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

crap!! wrong PR hold on

@gonuke
Copy link
Member Author

gonuke commented Jun 7, 2015

Nope.. it's OK. You already merged #111. The last few commits are more related to that, so this should be good to go on top of that merge.

FlanFlanagan added a commit that referenced this pull request Jun 7, 2015
@FlanFlanagan FlanFlanagan merged commit 23cd440 into cyclus:v1.3.0-release Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants