Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Libxml++ requirement from build #634

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Remove Libxml++ requirement from build #634

merged 2 commits into from
Oct 25, 2024

Conversation

bennibbelink
Copy link
Contributor

@bennibbelink bennibbelink commented Oct 24, 2024 •
edited
Loading

I was working on the cycamore_dev conda build and it demonstrated to me that we don't actually need Libxml++ to build cycamore. This PR removes it as a CMake build requirement

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Build Status Report - 9738613 - 2024-10-24 17:43:18 -0400

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_24.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_24.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_24.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_24.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@bennibbelink bennibbelink marked this pull request as ready for review October 24, 2024 21:47
@bennibbelink bennibbelink requested a review from gonuke October 24, 2024 21:48
gonuke
gonuke approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works - thanks @bennibbelink

@gonuke gonuke merged commit f0cfd77 into cyclus:main Oct 25, 2024
14 checks passed
@bennibbelink bennibbelink deleted the test-conda-dev branch October 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennibbelink @gonuke