Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export incorporate to enable Cycle React JSX pragma #3

Merged
merged 1 commit into from
May 2, 2019

Conversation

sliptype
Copy link
Contributor

@sliptype sliptype commented May 2, 2019

Summary

I'm working on a pragma to support JSX when rendering React components in Cycle.

To support the MVI architecture and the special sel prop I need access to incorporate.

Changes

  • Export incorporate from ./incorporate in src/index.ts

@staltz
Copy link
Member

staltz commented May 2, 2019

This seems like an easy win, thanks for the PR!

Once you're satisfied with cycle-react-pragma (e.g. after it has Babel support), would you also be interested in sending a PR to put the pragma in this repo?

@staltz staltz merged commit 8ef4ab7 into cyclejs:master May 2, 2019
@staltz
Copy link
Member

staltz commented May 2, 2019

Released 2.1.0

@sliptype
Copy link
Contributor Author

sliptype commented May 2, 2019

Thanks for the quick response!

Yeah, I will definitely make a PR once it's polished. I think this will be really cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants