Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker action #416

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Use Docker action #416

merged 2 commits into from
Jun 10, 2022

Conversation

inductor
Copy link
Contributor

@inductor inductor commented Jun 6, 2022

This PR improves Docker build cache using Docker official build action instead of using shell script.

uses: docker/build-push-action@v2
with:
builder: ${{ steps.buildx.outputs.name }}
push: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also test docker build on each commit if you set this as false on other action triggers.

Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
As we are migrating to Docker's GitHub Actions, your commit is very helpful for us.
We welcome your feedback and further commits:-)

Copy link
Contributor

@umezawatakeshi umezawatakeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thank you!

@umezawatakeshi umezawatakeshi merged commit bfe61f8 into cybozu-go:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants