Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark generated files in .gitattributes #97

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Oct 14, 2023

This PR is a simple improvement to the review process by using the feature described here: https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github

With this merged it will be a lot simpler to review PRs affecting generated files, as the marked as generated files will be collapsed by default in the PR diff-view. Example: #96 will be easier to review and comment on.

Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope merged commit 19cb615 into cybozu-go:main Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants