Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DisablePropagateGenerated feature gate #92

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Oct 3, 2023

This adds a temporary/experimental feature gate that allows a user to disable the Annotating a resource to propagate resources created from it feature. As the Accurate controller works at present, we need a way to prevent Accurate from touching resources in namespaces that are not and never will be, managed by Accurate.

The idea is to deprecate and eventually remove this new feature gate when the root cause is fixed.

Relates to #87 (workaround)

$ bin/accurate-controller --help
accurate controller

Usage:
  accurate-controller [flags]

Flags:
      --add_dir_header                    If true, adds the file directory to the header of the log messages
      --alsologtostderr                   log to standard error as well as files (no effect when -logtostderr=true)
      --apiserver-qps-throttle int        The maximum QPS to the API server. (default 50)
      --cert-dir string                   webhook certificate directory
      --config-file string                Configuration file path (default "/etc/accurate/config.yaml")
      --feature-gates mapStringBool       A set of key=value pairs that describe feature gates for alpha/experimental features. Options are:
                                          AllAlpha=true|false (ALPHA - default=false)
                                          AllBeta=true|false (BETA - default=false)
                                          DisablePropagateGenerated=true|false (ALPHA - default=false)

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@zoetrope could you take another look?

Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope merged commit 1cc371d into cybozu-go:main Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants