Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubectl-accurate template list sub command. #9

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Add kubectl-accurate template list sub command. #9

merged 6 commits into from
Aug 12, 2021
+134 −6

Conversation

d-kuro
Copy link
Contributor

@d-kuro d-kuro commented Aug 4, 2021

ref: #3

@d-kuro d-kuro self-assigned this Aug 4, 2021
@d-kuro d-kuro marked this pull request as ready for review August 8, 2021 11:26
@d-kuro d-kuro requested a review from ymmt2005 August 8, 2021 11:26
ymmt2005
ymmt2005 requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add kubectl-accurate sub list as an alias for kubectl-accurate list.

Please add this as a separate commit.

cmd/kubectl-accurate/sub/template_list.go Outdated Show resolved Hide resolved
cmd/kubectl-accurate/sub/template_list.go Outdated Show resolved Hide resolved
cmd/kubectl-accurate/sub/template_list.go Outdated Show resolved Hide resolved
d-kuro and others added 2 commits August 10, 2021 21:59
@d-kuro @ymmt2005
Fix description
6524f23 
Co-authored-by: Yamamoto, Hirotaka <[email protected]>
@d-kuro @ymmt2005
Fix error message.
1172dd5 
Co-authored-by: Yamamoto, Hirotaka <[email protected]>
@d-kuro
Copy link
Contributor Author

d-kuro commented Aug 11, 2021

@ymmt2005
Add kubectl-accurate sub list command:
ff11d6c

@d-kuro d-kuro requested a review from ymmt2005 August 11, 2021 13:46
ymmt2005
ymmt2005 requested changes Aug 11, 2021
View reviewed changes
docs/kubectl-accurate.md Outdated Show resolved Hide resolved
@d-kuro @ymmt2005
Fix description.
7d9030c 
Co-authored-by: Yamamoto, Hirotaka <[email protected]>
ymmt2005
ymmt2005 approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit cd1c38f into main Aug 12, 2021
@ymmt2005 ymmt2005 deleted the d-kuro/glob branch August 12, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 approved these changes

Assignees

@d-kuro d-kuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-kuro @ymmt2005