-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kubernetes 1.24 #57
Conversation
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
@@ -74,9 +73,9 @@ check-generate: | |||
.PHONY: envtest | |||
envtest: setup-envtest | |||
source <($(SETUP_ENVTEST) use -p env); \ | |||
TEST_CONFIG=1 go test -v -count 1 -race ./pkg/config -ginkgo.progress -ginkgo.v -ginkgo.failFast | |||
TEST_CONFIG=1 go test -v -count 1 -race ./pkg/config -ginkgo.progress -ginkgo.v -ginkgo.fail-fast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ginkgo said as follows.
--ginkgo.failFast is deprecated, use --ginkgo.fail-fast instead
Learn more at:https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
e2e/e2e_test.go
Outdated
// some ServiceAccounts that have been created before the upgrade might have the secrets field. | ||
// In this case, accurate should not copy the field. | ||
kubectlSafe(serviceAccountWithDummySecretsYAML, "apply", "-f", "-") | ||
Consistently(func() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The creation of sn1/test
should be waited with Eventually()
.
This Consistently()
can fail if the creation of sn1/test
ServiceAccount is delayed.
As far as I know kubectl apply
above is synchronous only for subroot1/test
, not for sn1/test
.
Once sn1/test
is created, it would be enough to check the contents of the ServiceAccount just once because we know that the ServiceAccount is created atomically.
To test the stability of sn1/test
seems excess for me.
You can check the contents even inside Eventually()
as done in the previous It()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Consistently() can fail if the creation of sn1/test ServiceAccount is delayed.
Thank you. That's true. If the test machine has low spec, this test may be fail.
I'll use Eventually()
.
Signed-off-by: Masayuki Ishii <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#55
Support Kubernetes 1.24 and update dependencies.
And I update e2e test due to the following change in k8s 1.24.
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.24.md#urgent-upgrade-notes
Signed-off-by: Masayuki Ishii [email protected]