Add role to view all resources for propagate resource #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
reviewed
Sep 30, 2021
api/v1/zz_generated.deepcopy.go
Outdated
| @@ -1,3 +1,4 @@ | |||
| //go:build !ignore_autogenerated | |||
There was a problem hiding this comment.
This is an auto-generated file, so do not edit it by hand.
ymmt2005
requested changes
Sep 30, 2021
| @@ -29,6 +29,7 @@ type SubNamespaceReconciler struct { | |||
| //+kubebuilder:rbac:groups=accurate.cybozu.com,resources=subnamespaces/status,verbs=get;update;patch | |||
| //+kubebuilder:rbac:groups=accurate.cybozu.com,resources=subnamespaces/finalizers,verbs=update | |||
| //+kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch;create;update;patch;delete | |||
| //+kubebuilder:rbac:groups=*,resources=*,verbs=get;list;watch | |||
There was a problem hiding this comment.
This comment should be added to controllers/propagate.go.
kmdkuk
changed the title
kmdkuk
force-pushed
the
add-role-to-view-all-resources
branch
from
cb2510d to
d9e29be
Compare
Signed-off-by: kouki <[email protected]>
kmdkuk
force-pushed
the
add-role-to-view-all-resources
branch
from
d9e29be to
3dfde45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20
Signed-off-by: kouki [email protected]