fix: should ignore create errors when namespace terminating #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a log-spam issue in busy clusters. Accurate should just ignore namespace terminating errors on create. If not, the logs are filled with annoying errors like this (example):
{"level":"error","ts":"2024-06-04T11:22:32Z","msg":"failed to handle deleted object","controller":"rolebinding","controllerGroup":"rbac.authorization.k8s.io","controllerKind":"RoleBinding","RoleBinding":{"name":"gitops-admins","namespace":"strm-rev-r-5d7d3652a0"},"namespace":"strm-rev-r-5d7d3652a0","name":"gitops-admins","reconcileID":"f5ab2512-5558-4d2b-92e0-cba652a84eca","error":"failed to re-create strm-rev-r-5d7d3652a0/gitops-admins: rolebindings.rbac.authorization.k8s.io \"gitops-admins\" is forbidden: unable to create new content in namespace strm-rev-r-5d7d3652a0 because it is being terminated","stacktrace":"github.com/cybozu-go/accurate/controllers.(*PropagateController).Reconcile\n\t/work/controllers/propagate.go:90\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s...I created a simple helper to make this code a bit more readable. Hope you like it! It might be possible to make further improvements with even more consistent error handling.