Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate user-facing propagate-generated annotation #113

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: deprecate user-facing propagate-generated annotation #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions controllers/propagate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ var _ = Describe("SubNamespace controller", func() {
cm1 := &corev1.ConfigMap{}
cm1.Namespace = rootNS
cm1.Name = "cm-generate"
//lint:ignore SA1019 subject for removal
cm1.Annotations = map[string]string{constants.AnnPropagateGenerated: constants.PropagateUpdate}
cm1.Data = map[string]string{"foo": "bar"}
err := k8sClient.Create(ctx, cm1)
Expand Down
6 changes: 4 additions & 2 deletions pkg/constants/meta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ const (

// Annotations
const (
AnnFrom = MetaPrefix + "from"
AnnPropagate = MetaPrefix + "propagate"
AnnFrom = MetaPrefix + "from"
AnnPropagate = MetaPrefix + "propagate"
// Deprecated: Part of the deprecated propagate-generated feature subject for
// removal soon.
AnnPropagateGenerated = MetaPrefix + "propagate-generated"
// Deprecated: Part of the deprecated propagate-generated feature subject for
// removal soon.
Expand Down