Setup applyconfiguration-gen with aqua #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoetrope
force-pushed
the
applyconfiggen-aqua
branch
from
a2ab9bc to
83663d8
Compare
ymmt2005
reviewed
Nov 15, 2023
| @@ -115,6 +115,7 @@ release-build: setup | |||
|
|
|||
| setup: | |||
| aqua i -l | |||
| aqua policy allow ./aqua-policy.yaml | |||
There was a problem hiding this comment.
Not sure, but doesn't this need to come before aqua i -l?
There was a problem hiding this comment.
Thanks!
That's right. I don't know why but CI passed 🤔
There was a problem hiding this comment.
@zoetrope
My guess is:
aqua -i linstalls only links to a hook script.- When the CI actually runs a command installed by Aqua, the hook script tries to install the real command.
- At that time,
aqua policy allowhas been run, so the hook script succeeds.
There was a problem hiding this comment.
Also note that we use aqua-installer action that runs aqua -i l by default.
https://aquaproj.github.io/docs/products/aqua-installer/#optional-inputs
zoetrope
force-pushed
the
applyconfiggen-aqua
branch
from
83663d8 to
c666d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.