Merge pull request #113 from erikgb/deprecate-propagate-generated-ann…

…otation chore: deprecate user-facing propagate-generated annotation
cybozu-go · Dec 11, 2023 · e24f4fc · e24f4fc
2 parents 38ea8a4 + f09b131
commit e24f4fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/controllers/propagate_test.go b/controllers/propagate_test.go
@@ -364,6 +364,7 @@ var _ = Describe("SubNamespace controller", func() {
 		cm1 := &corev1.ConfigMap{}
 		cm1.Namespace = rootNS
 		cm1.Name = "cm-generate"
+		//lint:ignore SA1019 subject for removal
 		cm1.Annotations = map[string]string{constants.AnnPropagateGenerated: constants.PropagateUpdate}
 		cm1.Data = map[string]string{"foo": "bar"}
 		err := k8sClient.Create(ctx, cm1)

diff --git a/pkg/constants/meta.go b/pkg/constants/meta.go
@@ -16,8 +16,10 @@ const (
 
 // Annotations
 const (
-	AnnFrom               = MetaPrefix + "from"
-	AnnPropagate          = MetaPrefix + "propagate"
+	AnnFrom      = MetaPrefix + "from"
+	AnnPropagate = MetaPrefix + "propagate"
+	// Deprecated: Part of the deprecated propagate-generated feature subject for
+	// removal soon.
 	AnnPropagateGenerated = MetaPrefix + "propagate-generated"
 	// Deprecated: Part of the deprecated propagate-generated feature subject for
 	// removal soon.